On Tue, Dec 15, 2020 at 12:54:51PM -0800, Andres Freund wrote:
> Minor nit: I'd put this into common/string.[ch], besides
> pg_clean_ascii(). Probably renaming it to pg_is_ascii().
Yeah. There is already one pg_is_ascii_string() in saslprep.c,
is_all_ascii() in collationcmds.c and string_is_ascii() in
pgp-pgsql.c. I don't think we need a fourth copy of the same logic,
even if it is dead simple.
--
Michael