RE: Perform streaming logical transactions by background workers and parallel apply

Поиск
Список
Период
Сортировка
От Hayato Kuroda (Fujitsu)
Тема RE: Perform streaming logical transactions by background workers and parallel apply
Дата
Msg-id TYAPR01MB5866B73F090BA597263AAD08F5CF9@TYAPR01MB5866.jpnprd01.prod.outlook.com
обсуждение исходный текст
Ответ на RE: Perform streaming logical transactions by background workers and parallel apply  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Ответы RE: Perform streaming logical transactions by background workers and parallel apply
Список pgsql-hackers
Dear Hou,

Thank you for updating the patch! Followings are comments.

1. config.sgml

```
+        the changes till logical_decoding_work_mem is reached. It can also be
```

I think it should be sandwiched by <varname>.

2. config.sgml

```
+        On the publisher side, <varname>logical_replication_mode</varname> allows
+        allows streaming or serializing changes immediately in logical decoding.
```

Typo "allows allows" -> "allows"

3. test general

You confirmed that the leader started to serialize changes, but did not ensure the endpoint.
IIUC the parallel apply worker exits after applying serialized changes, and it is not tested yet.
Can we add polling the log somewhere?


4. 015_stream.pl

```
+is($result, qq(15000), 'all changes are replayed from file')
```

The statement may be unclear because changes can be also replicated when streaming = on.
How about: "parallel apply worker replayed all changes from file"?


Best Regards,
Hayato Kuroda
FUJITSU LIMITED


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: New strategies for freezing, advancing relfrozenxid early
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Record queryid when auto_explain.log_verbose is on