RE: [Patch] Optimize dropping of relation buffers using dlist
| От | tsunakawa.takay@fujitsu.com |
|---|---|
| Тема | RE: [Patch] Optimize dropping of relation buffers using dlist |
| Дата | |
| Msg-id | TYAPR01MB2990CF10F21BFD6CC63AE5A8FE390@TYAPR01MB2990.jpnprd01.prod.outlook.com обсуждение исходный текст |
| Ответ на | RE: [Patch] Optimize dropping of relation buffers using dlist ("k.jamison@fujitsu.com" <k.jamison@fujitsu.com>) |
| Ответы |
RE: [Patch] Optimize dropping of relation buffers using dlist
|
| Список | pgsql-hackers |
In v15: (1) + for (cur_blk = firstDelBlock[j]; cur_blk < nblocks; cur_blk++) The right side of "cur_blk <" should not be nblocks, because nblocks is not the number of the relation fork anymore. (2) + BlockNumber nblocks; + nblocks = smgrnblocks(smgr_reln, forkNum[j]) - firstDelBlock[j]; You should either: * Combine the two lines into one: BlockNumber nblocks = ...; or * Put an empty line between the two lines to separate declarations and execution statements. After correcting these, I think you can check the recovery performance. Regards Takayuki Tsunakawa
В списке pgsql-hackers по дате отправления: