On Tuesday, December 9, 2025 1:34 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Dec 8, 2025 at 1:06 PM Chao Li <li.evan.chao@gmail.com> wrote:
> >
> > I have nit comment:
> >
> > ```
> > - if (ShutdownRequestPending)
> > + if (SlotSyncCtx->stopSignaled)
> > {
> > ereport(LOG,
> > - errmsg("replication slot synchronization worker is shutting
> down on receiving SIGINT"));
> > + errmsg("replication slot
> > + synchronization worker is shutting down because promotion is
> > + triggered"));
> > ```
> >
> > In the error message, “because promotion is triggered" sound a little
> redundant, can be just:
> >
> > "replication slot synchronization worker is shutting down due to promotion"
> >
>
> We have a number of existing similar messages like: "logical replication
> parallel apply worker for subscription \"%s\" will stop because of a parameter
> change". So, how about: "replication slot synchronization worker will stop
> because promotion is triggered"?
The suggested message looks better. Here is the updated patch which
can be applied to all branches that supports slotsync.
Best Regards,
Hou zj