Dear hackers,
I have been concerned that the patch has not been tested by cfbot due to the
application error. Also, some comments were raised. Therefore, I created a patch
to move forward.
I also tried to address some comments which is not so claimed by others.
They were included in 0003 patch.
* 0001 patch
It is almost the same as v3-0001, which was posted by Euler.
An unnecessary change for Mkvcbuild.pm (this file was removed) was ignored.
* 0002 patch
This contains small fixes to keep complier quiet.
* 0003 patch
This addresses comments posted to -hackers. For now, this does not contain a doc.
Will add if everyone agrees these idea.
1.
An option --port was added to control the port number for physical standby.
Users can specify a port number via the option, or an environment variable PGSUBPORT.
If not specified, a fixed value (50111) would be used.
SOURCE: [1]
2.
A FATAL error would be raised if --subscriber-conninfo specifies non-local server.
SOURCE: [2]
3.
Options -o/-O were added to specify options for publications/subscriptions.
SOURCE: [2]
4.
Made standby to save their output to log file.
SOURCE: [2]
5.
Unnecessary Assert in drop_replication_slot() was removed.
SOURCE: [3]
How do you think?
Thanks Shlok and Vignesh to work with me offline.
[1]:
https://www.postgresql.org/message-id/TY3PR01MB988978C7362A101927070D29F56A2%40TY3PR01MB9889.jpnprd01.prod.outlook.com
[2]:
https://www.postgresql.org/message-id/TY3PR01MB9889593399165B9A04106741F5662%40TY3PR01MB9889.jpnprd01.prod.outlook.com
[3]: https://www.postgresql.org/message-id/CALDaNm098Jkbh%2Bye6zMj9Ro9j1bBe6FfPV80BFbs1%3DpUuTJ07g%40mail.gmail.com
Best Regards,
Hayato Kuroda
FUJITSU LIMITED