RE: auto_explain: Include JIT output if applicable

Поиск
Список
Период
Сортировка
От Shinoda, Noriyoshi (PN Japan GCS Delivery)
Тема RE: auto_explain: Include JIT output if applicable
Дата
Msg-id TU4PR8401MB04302231DCF0E0B1D9252936EEED0@TU4PR8401MB0430.NAMPRD84.PROD.OUTLOOK.COM
обсуждение исходный текст
Ответ на Re: auto_explain: Include JIT output if applicable  (Lukas Fittl <lukas@fittl.com>)
Ответы Re: auto_explain: Include JIT output if applicable  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers

Hi,

 

I tried this feature.

I think that 'if (es->costs)' of the source code auto_explain.c will always be ‘true’.

 

Because it is not changed after 'es-> cost = true' in NewExplainState () function several rows ago.

So I attached a patch to delete this if statement.

 

Regards,

Noriyoshi Shinoda

 

From: Lukas Fittl [mailto:lukas@fittl.com]
Sent: Tuesday, September 25, 2018 6:38 AM
To: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: auto_explain: Include JIT output if applicable

 

On Mon, Sep 24, 2018 at 1:48 PM, Andres Freund <andres@anarazel.de> wrote:

Thanks for noticing - pushed!

 

Thanks!

 

Best,

Lukas

 

--

Lukas Fittl

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] Something for the TODO list: deprecating abstime and friends
Следующее
От: Andres Freund
Дата:
Сообщение: Re: auto_explain: Include JIT output if applicable