Re: Re: [COMMITTERS] pgsql: Fix brain fade in DefineIndex(): it was continuing to access the

Hi Tom and Andrew,

On Thu, 30 Aug 2007, Tom Lane wrote:

> Date: Thu, 30 Aug 2007 10:04:34 -0400
> From: Tom Lane <tgl@sss.pgh.pa.us>
> To: Andrew Dunstan <andrew@dunslane.net>
> Cc: ohp@pyrenet.fr, PostgreSQL-development <pgsql-hackers@postgresql.org>
> Subject: Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix brain fade in
>     DefineIndex(): it was continuing to access the
>
> Andrew Dunstan <andrew@dunslane.net> writes:
> > ohp@pyrenet.fr wrote:
> >> I've just configure centaur (CentOS 5) like this.
> >> Do you need it for every version (8.1, 8.2) or just HEAD
> >> Do you need it just once a week or every run?
> >> I can also configure wharthog (unixware) like this if you need...
>
> > I have no idea - probably just HEAD, but Tom will have a better idea :-)
>
> HEAD only is enough IMHO.  If we find any bugs it should be pretty
> obvious whether they need to be back-patched.
>
>             regards, tom lane
>
While waiting for my application for another animal, I made some tests and
was surprised that cluster test failed with an ordering error.
Maybe an ORDER BY is missing in the test query.

Here's an exerpt of check.log:

============== creating temporary installation        ==============
============== initializing database system           ==============
============== starting postmaster                    ==============
running on port 55678 with pid 6928
============== creating database "regression"         ==============
CREATE DATABASE
ALTER DATABASE
============== installing plpgsql                     ==============
CREATE LANGUAGE
============== running regression test queries        ==============
parallel group (15 tests):  text name oid char float4 int2 boolean varchar int8 float8 int4 uuid bit enum numeric
boolean             ... ok    char                 ... ok    name                 ... ok    varchar              ... ok
  text                 ... ok    int2                 ... ok    int4                 ... ok    int8                 ...
ok   oid                  ... ok    float4               ... ok    float8               ... ok    bit
...ok    numeric              ... ok    uuid                 ... ok    enum                 ... ok
 
test strings              ... ok
test numerology           ... ok
parallel group (18 tests):  comments path lseg time timetz reltime polygon tinterval box circle abstime tstypes point
intervaltimestamptz timestamp date inet    point                ... ok    lseg                 ... ok    box
     ... ok    path                 ... ok    polygon              ... ok    circle               ... ok    date
        ... ok    time                 ... ok    timetz               ... ok    timestamp            ... ok
timestamptz         ... ok    interval             ... ok    abstime              ... ok    reltime              ... ok
  tinterval            ... ok    inet                 ... ok    tstypes              ... ok    comments             ...
ok
parallel group (5 tests):  geometry horology type_sanity oidjoins opr_sanity    geometry             ... ok    horology
           ... ok    oidjoins             ... ok    type_sanity          ... ok    opr_sanity           ... ok
 
test insert               ... ok
test create_function_1    ... ok
test create_type          ... ok
test create_table         ... ok
test create_function_2    ... ok
parallel group (2 tests):  copy copyselect    copy                 ... ok    copyselect           ... ok
parallel group (8 tests):  create_operator create_aggregate vacuum drop_if_exists create_misc constraints inherit
triggers   constraints          ... ok    triggers             ... ok    create_misc          ... ok
create_aggregate    ... ok    create_operator      ... ok    inherit              ... ok    vacuum               ... ok
  drop_if_exists       ... ok
 
parallel group (2 tests):  create_view create_index    create_index         ... ok    create_view          ... ok
test sanity_check         ... ok
test errors               ... ok
test select               ... ok
parallel group (20 tests):  select_distinct_on btree_index select_into delete select_distinct namespace update
hash_indexselect_having union case random select_implicit prepared_xacts aggregates transactions subselect portals join
arrays   select_into          ... ok    select_distinct      ... ok    select_distinct_on   ... ok    select_implicit
  ... ok    select_having        ... ok    subselect            ... ok    union                ... ok    case
     ... ok    join                 ... ok    aggregates           ... ok    transactions         ... ok    random
        ... ok    portals              ... ok    arrays               ... ok    btree_index          ... ok
hash_index          ... ok    update               ... ok    namespace            ... ok    prepared_xacts       ... ok
  delete               ... ok
 
test privileges           ... ok
test misc                 ... ok
parallel group (9 tests):  select_views combocid guc portals_p2 dependency tsearch cluster rules foreign_key
select_views        ... ok    portals_p2           ... ok    rules                ... ok    foreign_key          ... ok
  cluster              ... FAILED    dependency           ... ok    guc                  ... ok    combocid
...ok    tsearch              ... ok
 
parallel group (18 tests):  limit xml plancache rowtypes prepare sequence temp without_oid largeobject copy2
polymorphismconversion returning truncate rangefuncs domain alter_table plpgsql    plancache            ... ok    limit
              ... ok    plpgsql              ... ok    copy2                ... ok    temp                 ... ok
domain              ... ok    rangefuncs           ... ok    prepare              ... ok    without_oid          ... ok
  conversion           ... ok    truncate             ... ok    alter_table          ... ok    sequence             ...
ok   polymorphism         ... ok    rowtypes             ... ok    returning            ... ok    largeobject
...ok    xml                  ... ok
 
test stats                ... ok
test tablespace           ... ok
============== shutting down postmaster               ==============
server stopped

========================1 of 111 tests failed.
========================

The differences that caused some tests to fail can be viewed in the
file "./regression.diffs".  A copy of the test summary that you see
above is saved in the file "./regression.out".

make: *** [check] Erreur 1


================== pgsql.25500/src/test/regress/regression.diffs ===================
*** ./expected/cluster.out    Fri Aug 31 16:08:02 2007
--- ./results/cluster.out    Fri Aug 31 16:30:32 2007
***************
*** 252,259 **** SELECT conname FROM pg_constraint WHERE conrelid = 'clstr_tst'::regclass;     conname
----------------
-  clstr_tst_pkey  clstr_tst_con (2 rows)
 SELECT relname, relkind,
--- 252,259 ---- SELECT conname FROM pg_constraint WHERE conrelid = 'clstr_tst'::regclass;     conname ----------------
clstr_tst_con
 
+  clstr_tst_pkey (2 rows)
 SELECT relname, relkind,

======================================================================

Best regards
-- 
Olivier PRENANT                    Tel: +33-5-61-50-97-00 (Work)
15, Chemin des Monges                +33-5-61-50-97-01 (Fax)
31190 AUTERIVE                       +33-6-07-63-80-64 (GSM)
FRANCE                          Email: ohp@pyrenet.fr
------------------------------------------------------------------------------
Make your life a dream, make your dream a reality. (St Exupery)