Re: pgsql: Fix compiler warnings on 64-bit boxes:

Поиск
Список
Период
Сортировка
От Gavin Sherry
Тема Re: pgsql: Fix compiler warnings on 64-bit boxes:
Дата
Msg-id Pine.LNX.4.58.0609061730360.6458@linuxworld.com.au
обсуждение исходный текст
Ответ на pgsql: Fix compiler warnings on 64-bit boxes: difference between  (teodor@postgresql.org (Teodor Sigaev))
Ответы Re: pgsql: Fix compiler warnings on 64-bit boxes:  (Teodor Sigaev <teodor@sigaev.ru>)
Re: pgsql: Fix compiler warnings on 64-bit boxes:  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers
On Wed, 6 Sep 2006, Teodor Sigaev wrote:

> Log Message:
> -----------
> Fix compiler warnings on 64-bit boxes: difference between
> pointers are int64, but warnings are emitted for position info in
> error messages in parser, so, just cast it to int32
>
> Modified Files:
> --------------
>     pgsql/contrib/hstore:
>         hstore_io.c (r1.1 -> r1.2)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/hstore/hstore_io.c.diff?r1=1.1&r2=1.2)


It might seem a minor quibble, but it seems like a more reliable approach
might be to cast to a 64 bit type and user a 64 bit int formatter.

It seems unlikely that state->ptr - state->begin would yield a number that
large but I don't know that that would be true of every platform or user.

Thanks,

Gavin

В списке pgsql-committers по дате отправления:

Предыдущее
От: teodor@postgresql.org (Teodor Sigaev)
Дата:
Сообщение: pgsql: Fix compiler warnings on 64-bit boxes: difference between
Следующее
От: Teodor Sigaev
Дата:
Сообщение: Re: pgsql: Fix compiler warnings on 64-bit boxes: