Re: minor fix of elevel in fd.c

Поиск
Список
Период
Сортировка
От Qingqing Zhou
Тема Re: minor fix of elevel in fd.c
Дата
Msg-id Pine.LNX.4.58.0606122143310.27449@eon.cs
обсуждение исходный текст
Ответ на Re: minor fix of elevel in fd.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: minor fix of elevel in fd.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-patches

On Mon, 12 Jun 2006, Tom Lane wrote:

> "Qingqing Zhou" <zhouqq@cs.toronto.edu> writes:
> > AllocateFile() and AllocateDir() should return the control to the caller
> > since we might want to upgrade the elevel.
>
> That is not what we do for upgrading errors.  Use a critical section in
> a caller that doesn't want elog(ERROR).
>

True, but current code just check the return value of AllocateABC() then
decide to upgrade elevel to FATAL. This is ok if we allow AllocateABC()
don't elog(ERROR) themselves.

Regards,
Qingqing



В списке pgsql-patches по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: Bitmap index AM
Следующее
От: Tom Lane
Дата:
Сообщение: Re: minor fix of elevel in fd.c