On Mon, 9 Jul 2001, Barry Lind wrote:
> Anders,
>
> I have some issues with this patch.
>
> 1) Please don't require the driver to perform yet another round trip to
> the server to get the database encoding. You changed the following code
> which accessed the server once at connection creation:
[snip]
> 2) I don't like having test specific code in Encoding.java, specifically
> the dummy encoding 'X-UNIT-TESTS'.
Thanks Barry, I'll fix these things and return with a new patch.
I think I'll be able to get pretty good test coverage even without the
extra test data.
/Anders
_____________________________________________________________________
A n d e r s B e n g t s s o n ndrsbngtssn@yahoo.se
Stockholm, Sweden
_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com