Re: [PATCHES] encoding names

Tatsuo Ishii writes:

> > But getdbencoding isn't semantically different from the old
> > getdatabaseencoding.  "encoding" isn't the right term anyway, methinks, it
> > should be "character set".  So maybe database_character_set()?  (No "get"
> > please.)
>
> I'm not a native English speaker, so please feel free to choose more
> appropriate name.
>
> BTW, what's wrong with "encoding"? I don't think, for example EUC-JP
> or utf-8, are character set names.

Hmm, SQL talks of character sets, it has a CHARACTER_SETS view and such.
It's slightly incorrect, I agree.

Maybe we should not touch getdatabaseencoding() right now, given that the
names we currently use are apparently almost correct anyway and
considering the pain it creates to alter them, and instead implement the
information schema views in the future?

-- 
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter