Re: [PATCH] Partial indicies again

Martijn van Oosterhout writes:

> Well, getting closer. Maybe I should start version numbering the patches?

For one thing, you might want to post them to pgsql-patches instead.  And
you should start generating the patches against the 7.2devel sources
because I already suspect yours generating conflicts.

> * Updates to the documentation as well as comments within the code. If you
>   see a spot I missed, let me know.

FYI, it's called partial "indexes".

> * Make it pg_dump-able. I've tried to extract the expression out the of
>   system tables by using stringToNode and deparse_expression but it doesn't
>   seem to work. I keep getting the error: "get_names_for_var: bogus
>   varlevelsup 0". Anyone know what's going on? See attachment <<expr.c>>.

It might be an option to store the unparsed condition in the system
catalogs, similar to what is done with the default values (see
pg_attrdef).

--
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter