Re: encode in base code

Поиск
Список
Период
Сортировка
Искать
От
Peter Eisentraut
Тема
Re: encode in base code
Дата
Msg-id
Pine.LNX.4.30.0107021944340.677-100000@peter.localdomain
Ответ на
encode in base code (Marko Kreen)
Список
Дерево обсуждения
encode in base code Marko Kreen <marko@l-t.ee>
Re: encode in base code Bruce Momjian <pgman@candle.pha.pa.us>
Re: encode in base code Bruce Momjian <pgman@candle.pha.pa.us>
Re: encode in base code Peter Eisentraut <peter_e@gmx.net>
Re: encode in base code Marko Kreen <marko@l-t.ee>
Re: encode in base code Peter Eisentraut <peter_e@gmx.net>
Re: encode in base code Marko Kreen <marko@l-t.ee>
Re: encode in base code Bruce Momjian <pgman@candle.pha.pa.us>
Marko Kreen writes:

> Put encode() into base system.  Used part of Alex' patch
> for docs, hope he does not mind ;)

Please use #include "", not #include <>, for PostgreSQL's header files.

Would you mind changing the copyright to match the rest of the source?

Put everything in encode.c (not varlena.c), and put encode.c in utils/adt.

I think we've covered before that 'uint' is not a standard data type.
VARSIZE is of type int32 (signed).

To convert from text to C string, use textout().

Also, I think the term "encode" is already overloaded for multibyte use.
Maybe it needs to be qualified, such as "binary_encode".

-- 
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter

В списке pgsql-patches по дате отправления
От: Bruce Momjian
Дата:
Сообщение: Re: encode in base code
От: Marko Kreen
Дата:
Сообщение: Re: encode in base code
FAQ