Re: [current] readline breakage

I have checked this in:

*** tab-complete.c      2001/06/11 22:12:48     1.33
--- tab-complete.c      2001/06/20 18:37:09
***************
*** 62,67 ****
--- 62,70 ----
 #ifdef HAVE_RL_FILENAME_COMPLETION_FUNCTION #define filename_completion_function rl_filename_completion_function
+ #else
+ /* missing in some header files */
+ extern char *filename_completion_function(); #endif
 #ifdef HAVE_RL_COMPLETION_MATCHES

I hope it still works for both of you. ;-)


Jason Tishler writes:

> Peter,
>
> On Sun, Jun 17, 2001 at 12:08:59PM +0200, Peter Eisentraut wrote:
> > Jason Tishler writes:
> >
> > > Shouldn't the declaration for filename_completion_function() be picked up
> > > via readline.h?  IMO, redeclaring functions especially from an external
> > > library (i.e., readline) is generally not considered good programming
> > > practice.
> >
> > It should, but on some systems it evidently isn't.  But since on Cygwin a
> > correct import/export decorated declaration should be in the header files,
> > would a second declaration without those attributes override or otherwise
> > interfere with that?
>
> No, after applying the attached patch, Cygwin psql built against readline
> 4.2 without any problems.  After some reflection, this outcome should
> have been obvious to me since my previous distributions built fine with
> the duplicate (but different) filename_completion_function() declarations.
>
> Note that I did not test this patch against the other three configuration
> that I used to test my original patch but I would not anticipate any issues
> with these configurations either.
>
> > Otherwise I might have to stick it back covered by some #ifdef's.
>
> The #ifdefs do not appear to be necessary.
>
> Do you want to submit this patch to pgsql-patches or should I?
>
> Thanks,
> Jason
>
>

-- 
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter