Re: PostgreSQL 7.1 now in OpenBSD ports/packages

Peter Galbavy writes:

> Thanks to Brandon Palmer (with some help from myself) PostgreSQL
> 7.1 is now in the OpenBSD ports tree. It made it in just before the
> 2.9 tree lock and should, all willing, make it onto the 2.9 CD's
> (around June) as a binary package.

Coupla comments:

In the port Makefile you have

CONFIGURE_ENV=  POSTGRESDIR="${PREFIX}" LIBS=-lcurses
CONFIGURE_ARGS= --enable-syslog \
                --disable-rpath \
                --with-CXX \
                --datadir="${PREFIX}/share/examples/postgresql" \
                --docdir="${PREFIX}/share/doc/postgresql"

Firstly, POSTGRESDIR doesn't do anything, you want to use the --prefix
option.  (This is done automatically, so in consequence you can just
remove this.)  Secondly, configure should pick up -lcurses automatically
when it needs it (which it probably doesn't).

I don't know why you set --datadir the way you do, but note that datadir
does not contain any examples.  In a full installation, datadir contains
files required for initdb, pgaccess, the JDBC driver, and some *.sql
files.  You probably just want to leave off this option, which will give
you the right default.

Later in Makefile

MAKE_ENV=       USE_TCL=true TCL_INCDIR="${TCL_INCDIR}" \
                TK_INCDIR="${TK_INCDIR}"

This is probably a relict from the past.


CONFIGURE_ARGS+= --with-openssl=/etc

I don't think you install OpenSSL under /etc.

FAKE_FLAGS=     POSTGRESDIR="${WRKINST}${PREFIX}"

No, you want to use gmake install DESTDIR=/else/where.  POSTGRESDIR
doesn't do anything.

post-install:
[...]
        @cd ${WRKSRC}/doc && \
                ${MAKE_PROGRAM} PGDOCS="${PREFIX}/share/doc/postgresql" all
        ${INSTALL_DATA} ${WRKSRC}/doc/*.ps* ${PREFIX}/share/doc/postgresql

The documentation is installed by default, there is no need to do anything
special.  *.ps files are not shipped in the tarball, you need to download
them separately if you want them.

That's it.  Nice work.

--
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter