Re: RPMS for 7.1beta3 being uploaded.

Lamar Owen writes:

> > | diff -uNr postgresql-7.1beta3.orig/src/Makefile.shlib postgresql-7.1beta3/src/Makefile.shlib
> > | -  LINK.shared          = $(COMPILER) -shared -Wl,-soname,$(soname)
> > | +  LINK.shared          = $(COMPILER) -shared -Wl
> > |  endif
>
> > This cannot possibly be right.
>
> It's what you recommended a while back.  See the discussions on -soname
> from the libpq.so.2.1 versus libpq.so.2.0 thread awhile back.

The patch I recommended was

-  LDFLAGS_SL            := -Bdynamic -shared -soname $(shlib)
+  LDFLAGS_SL            := -Bdynamic -shared -soname lib$(NAME)$(DLSUFFIX).$(SO_MAJOR_VERSION)

but that's not what your patch does.  The issue is fixed, you shouldn't
patch anything.

> > I think this should be fixed to read
> >
> > #! /usr/bin/env perl
>
> No, for a RedHat or any other Linux distribution, /usr/bin is where perl
> and python (or their symlinks) will always live.

I was thinking in terms of fixing this in the source tree.

> > There is no '--with-x'.  '--with-tk' is the default if '--with-tcl' was
> > given; you should use '--without-tk' if you don't want it.
>
> There was in the past a --with-x.

But it never did anything.

-- 
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/