Re: BeOS Files & diff's
От | Peter Eisentraut |
---|---|
Тема | Re: BeOS Files & diff's |
Дата | |
Msg-id | Pine.LNX.4.21.0006090240070.23619-100000@localhost.localdomain обсуждение исходный текст |
Ответ на | BeOS Files & diff's ("David Reid" <dreid@jetnet.co.uk>) |
Список | pgsql-patches |
David Reid writes: > Here is the first batch of files and diffs for the BeOS port. Looks pretty straightforward, just some minor comments. I'd be happy to help with anything. Please avoid any #ifdef __BEOS__ etc as much as possible. For example, there isn't a good reason to do this +#ifndef __BEOS__ #ifndef __cplusplus #ifndef bool typedef char bool; @@ -80,6 +84,7 @@ #ifndef false #define false ((bool) 0) #endif +#endif /* __BEOS__ */ typedef bool *BoolPtr; unless your compiler is broken. To include SupportDefs.h, create a configure test for it. Please no -DBEOS, especially when __BEOS__ seems to be predefined. If you need to define this to get certain symbols defined in system header files, do it in configure.in; look at AC_AIX as an example. Also, please add comments to all platform specific stuff. Why do you define AF_UNIX to 1? Is it not predefined, or does BEOS have no domain sockets (in which case you have more work to do)? Also, patches should usually be formed with diff -cr to get them all into one file. -- Peter Eisentraut Sernanders väg 10:115 peter_e@gmx.net 75262 Uppsala http://yi.org/peter-e/ Sweden
В списке pgsql-patches по дате отправления: