Re: broken locale in 7.0.2 without multibyte support (FreeBSD 4.1-RELEASE) ?

On Sun, 3 Dec 2000, Tom Lane wrote:

> Date: Sun, 03 Dec 2000 18:13:47 -0500
> From: Tom Lane <tgl@sss.pgh.pa.us>
> To: Oleg Bartunov <oleg@sai.msu.su>
> Cc: pgsql-hackers@postgresql.org
> Subject: Re: [HACKERS] broken locale in 7.0.2 without multibyte support (FreeBSD 4.1-RELEASE) ? 
> 
> Oleg Bartunov <oleg@sai.msu.su> wrote a couple months ago:
> >>>> It's clear that we must use 'unsigned char' instead of 'char'
> >>>> and corrected version runs ok on both systems. That's why I suspect
> >>>> that gcc 2.95.2 has different default under FreeBSD which could
> >>>> cause problem with LC_CTYPE in 7.0.2 
> 
> > ok. will check this. I've recompile 7.0.2 on freebsd with -funsigned-char
> > and the problem has gone away. This prove my suggestion. I also 
> > checked 6.5 and it has the same probelm on FreeBSD. Also,
> > this makes clear many complains about broken locale under FreeBSD
> > I got from people. 
> > Hmm, current cvs has the same problem :-(
> 
> Today I inserted (unsigned char) casts into all the <ctype.h> function
> calls I could find.  This issue should be fixed as of current cvs.
> Please try it again when you have time.
> 

Just tried on FreeBSD 3.4-STABLE, current cvs, gcc version 2.95.2 
19991024 (release), ru-RU.KOI8-R locale, postgresql configured with
--enable-locale, no gcc option like --unisgned-chars
Looks like your changes did right job !
regards,
    Oleg


>             regards, tom lane
> 

_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83