On Mon, May 16, 2022 8:34 PM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com> wrote:
>
> Attach the new version patch.
>
Thanks for your patch. Here are some comments:
1. (0001 patch)
/*
* Returns Oids of tables in a publication.
*/
Datum
pg_get_publication_tables(PG_FUNCTION_ARGS)
Should we modify the comment of pg_get_publication_tables() to "Returns
information of tables in a publication"?
2. (0002 patch)
+ * Note that we don't support the case where column list is different for
+ * the same table when combining publications. But we still need to check
+ * all the given publication-table mappings and report an error if any
+ * publications have different column list.
*
* Multiple publications might have multiple column lists for this
* relation.
I think it would be better if we swap the order of these two paragraphs.
Regards,
Shi yu