RE: Handle infinite recursion in logical replication setup

On Wed, Sep 7, 2022 12:23 PM vignesh C <vignesh21@gmail.com> wrote:
> 
> 
> Thanks for the comments, the attached v47 patch has the changes for the
> same.
> 

Thanks for updating the patch.

Here is a comment.

+    for (i = 0; i < subrel_count; i++)
+    {
+        Oid            relid = subrel_local_oids[i];
+        char       *schemaname = get_namespace_name(get_rel_namespace(relid));
+        char       *tablename = get_rel_name(relid);
+
+        appendStringInfo(&cmd, "AND NOT (N.nspname = '%s' AND C.relname = '%s')\n",
+                         schemaname, tablename);
+    }

Would it be better to add "pfree(schemaname)" and "pfree(tablename)" after
calling appendStringInfo()?

Regards,
Shi yu