RE: doc patch: clarify the naming rule for injection_points

Поиск
Список
Период
Сортировка
От Hayato Kuroda (Fujitsu)
Тема RE: doc patch: clarify the naming rule for injection_points
Дата
Msg-id OSCPR01MB14966A5B704EF304E57FC9D57F5B82@OSCPR01MB14966.jpnprd01.prod.outlook.com
обсуждение исходный текст
Ответ на Re: doc patch: clarify the naming rule for injection_points  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: doc patch: clarify the naming rule for injection_points
Список pgsql-hackers
Dear Michael,

> > I also feel just converting lower case is not good. The point seems to locate in
> > the end-of-transaction callback and it accepts invalidation messages. Based on
> the
> > fact, how about "inval-process-invalidation-messages"?
> > 0002 did simple replacements of these words.
>
> -    INJECTION_POINT("heap_update-before-pin");
> +    INJECTION_POINT("heap-update-before-pin");
>
> The former name is better IMO.  heap_update() is the name of the
> function where the point is defined.
>
> -    INJECTION_POINT("AtEOXact_Inval-with-transInvalInfo");
> +    INJECTION_POINT("inval-process-invalidation-messages");
>
> This naming has been puzzling me, though, so a rename looks fit.  I am
> not sure that this is the best name that matches with this code path,
> as this lacks a reference regarding the end of a transaction.  Perhaps
> something like "end-transaction-process-inval" would be better?

Thanks for suggesting them. ISTM, you are correct. PSA updated version.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


Вложения

В списке pgsql-hackers по дате отправления: