RE: Patch for migration of the pg_commit_ts directory
От | Hayato Kuroda (Fujitsu) |
---|---|
Тема | RE: Patch for migration of the pg_commit_ts directory |
Дата | |
Msg-id | OSCPR01MB14966A30D6251B0AE867FEE54F5E0A@OSCPR01MB14966.jpnprd01.prod.outlook.com обсуждение исходный текст |
Ответ на | Re: Patch for migration of the pg_commit_ts directory (Maxim Orlov <orlovmg@gmail.com>) |
Список | pgsql-hackers |
Hi, Thanks for updating the patch. Regarding the check_track_commit_timestamp_parameter(), I'm not sure the function is needed. Since pg_controldata outputs whether the commit_ts module is enabled or not [1], can we obtain there instead? I imagined like we can add a new field at ControlData, it could be obtained in get_control_data(), values for instances could be compared in check_control_data(). Another possibility is that oldestCommitTsXid/newestCommitTsXid can be always valid if track_commit_timestamp is on. In this case the attribute is not needed anymore. It is enough to check these values. Can you check them? Regarding the test, I feel it is unnecessary long. I feel it is enough to ensure one or two transactions have the same timestamp on the both nodes, pgbench is not needed. Current test may not be able to finish on the slow machine. [1] ``` $ pg_controldata data/ | grep "track_" track_commit_timestamp setting: off ``` Best regards, Hayato Kuroda FUJITSU LIMITED
В списке pgsql-hackers по дате отправления: