RE: ReplicationSlotRelease() crashes when the instance is in the single user mode

Поиск
Список
Период
Сортировка
От Hayato Kuroda (Fujitsu)
Тема RE: ReplicationSlotRelease() crashes when the instance is in the single user mode
Дата
Msg-id OSCPR01MB149668B67979F8F4C73B69E2EF532A@OSCPR01MB14966.jpnprd01.prod.outlook.com
обсуждение исходный текст
Ответ на Re: ReplicationSlotRelease() crashes when the instance is in the single user mode  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Dear Michael and hackers,

This is a wrap-up of this thread. I'm planning to close the thread once.

> I am saying that there is little point in having tests for the origin
> functions in single-user mode as these don't do anything really
> fancy with global states (there's a acquired_by of course, and no
> specific IsUnderPostmaster patch), contrary to the replication slots.
> I am not convinced that there is any need to restrict them, either.
> If somebody shows a reason to justify such a move, we could argue
> about it, of course.

OK, thanks for the clarification. Yes, there are no special path for
single-user mode for origins.

Now, senior members recently appeared here are not so motivated to restrict some
operations in single-user mode unless it cannot be done in principle. Based on
that, I decided to close the thread once until someone raised another point.
For the reference purpose, I attached a patch which prohibits slot manipulation
in single-user mode. Anyone can update and use the patch for any purposes.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


Вложения

В списке pgsql-hackers по дате отправления: