RE: Logical Replication of sequences
От | Hayato Kuroda (Fujitsu) |
---|---|
Тема | RE: Logical Replication of sequences |
Дата | |
Msg-id | OSCPR01MB149667963060BB6A068B275B9F5EBA@OSCPR01MB14966.jpnprd01.prod.outlook.com обсуждение исходный текст |
Ответ на | Re: Logical Replication of sequences (vignesh C <vignesh21@gmail.com>) |
Ответы |
RE: Logical Replication of sequences
|
Список | pgsql-hackers |
Dear Vignesh, Thanks for updating the patch. Here are comments for 0002. ``` + if (pubrelkind == '\0') + return; ``` Instead of adding this part, can we provide another function which only checks the type mismatch? New one can be called from CreateSubscription() and AlterSubscription_refresh(). ``` +#include "nodes/primnodes.h" ... +typedef struct SubscriptionRelKind +{ + RangeVar *rv; + char relkind; +} ``` The data structure is used in subscriptioncmds.c. Can we move the definition to the file? Also, `relkind` indicates the type of relation on publisher. Can you clarify the point like `relkind_on_pub`? Best regards, Hayato Kuroda FUJITSU LIMITED
В списке pgsql-hackers по дате отправления: