RE: Resetting recovery target parameters in pg_createsubscriber
От | Hayato Kuroda (Fujitsu) |
---|---|
Тема | RE: Resetting recovery target parameters in pg_createsubscriber |
Дата | |
Msg-id | OSCPR01MB14966738A958D7059A14EBB5CF503A@OSCPR01MB14966.jpnprd01.prod.outlook.com обсуждение исходный текст |
Ответ на | Re: Resetting recovery target parameters in pg_createsubscriber (Alyona Vinter <dlaaren8@gmail.com>) |
Ответы |
Re: Resetting recovery target parameters in pg_createsubscriber
|
Список | pgsql-hackers |
Dear Alyona, Thanks for updating the patch! Sadly, your patch cannot be applied cleanly. Even after the manual merge, it could not be built. Maybe `dbinfo` should be `dbinfos.dbinfo`. Obtained message is written in [1]. (cfbot seemed not to run correctly) Regarding patch content, your patch restores the postgresql.auto.conf after the command runs. Initially I felt that it is enough to set below GUCs becasue only they are changed from the default. Is there a reason why you fully restore them? ``` recovery_target_inclusive true recovery_target_action pause recovery_target_lsn "" ``` [1] ``` ../postgres/src/bin/pg_basebackup/pg_createsubscriber.c: In function ‘main’: ../postgres/src/bin/pg_basebackup/pg_createsubscriber.c:2526:31: error: ‘dbinfo’ undeclared (first use in this function);did you mean ‘dbinfos’? 2526 | reset_recovery_params(dbinfo, subscriber_dir); | ^~~~~~ | dbinfos ``` Best regards, Hayato Kuroda FUJITSU LIMITED
В списке pgsql-hackers по дате отправления: