On Monday, September 11, 2023 9:22 PM Kuroda, Hayato/黒田 隼人 <kuroda.hayato@fujitsu.com> wrote:
>
> Thank you for reviewing! PSA new version.
Thanks for updating the patch, few cosmetic comments:
1.
#include "access/transam.h"
#include "catalog/pg_language_d.h"
+#include "fe_utils/string_utils.h"
#include "pg_upgrade.h"
It seems we don't need this head file anymore.
2.
+ if (*invalidated && SlotIsLogical(s) && IsBinaryUpgrade)
+ elog(ERROR, "Replication slots must not be invalidated during the upgrade.");
I think normally the first letter is lowercase, and we can avoid the period.
Best Regards,
Hou zj