Re: Propsed pgagent patch: pgAgent reports failure upon success - For Review

<p><font face="sans-serif" size="2">Hi Dave.</font><br /><br /><tt><font size="2">Dave Page <dpage@pgadmin.org>
wroteon 17/07/2012 10:45:28:<br /><br />> From: Dave Page <dpage@pgadmin.org></font></tt><br /><tt><font
size="2">>To: Martin French <Martin.French@romaxtech.com>, </font></tt><br /><tt><font size="2">> Cc:
pgadmin-hackers@postgresql.org,pgadmin-hackers-owner@postgresql.org</font></tt><br /><tt><font size="2">> Date:
17/07/201210:45</font></tt><br /><tt><font size="2">> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent
<br/>> reports failure upon success - For Review</font></tt><br /><tt><font size="2">> <br />> Hi<br />>
<br/>> This still seems to be malformed - I'm getting:<br />> <br />> raptor:pgagent dpage$ patch -p1 <
~/Downloads/pgagent.patch<br/>> (Stripping trailing CRs from patch.)<br />> patching file connection.cpp<br
/>>patch: **** malformed patch at line 6: if (result)<br />> <br />> Looking at the patch itself, it looks
likethe indentation is missing<br />> from the first hunk for connection.cpp:<br />> <br />> diff --git
a/connection.cppb/connection.cpp<br />> index 5e10078..6103c00 100644<br />> --- a/connection.cpp<br />> +++
b/connection.cpp<br/>> @@ -336,6 +336,7 @@ DBresult::DBresult(DBconn *conn, const wxString &query)<br />> if
(result)<br/>> {<br />> int rc = PQresultStatus(result);<br />> + conn->SetLastResult(rc);<br />> if (rc
==PGRES_TUPLES_OK)<br />> maxRows = PQntuples(result);<br />> else if (rc != PGRES_COMMAND_OK)<br />> <br
/>>If I look at the source file, it's more like this (he says, hoping<br />> Gmail doesn't mangle it):<br />>
<br/>>         if (result)<br />>         {<br />>                 int rc = PQresultStatus(result);<br />>
               if (rc == PGRES_TUPLES_OK)<br />>                         maxRows = PQntuples(result);<br />>    
           else if (rc != PGRES_COMMAND_OK)<br />> <br />> How are you generating the patch? Has your unmodified
versionbeen<br />> inadvertently modified?<br />> <br />> On Tue, Jul 17, 2012 at 7:22 AM, Martin French<br
/>><Martin.French@romaxtech.com> wrote:<br />> > (See attached file: pgAgent.patch)<br />> ><br
/>>> Hi<br />> ><br />> > pgadmin-hackers-owner@postgresql.org wrote on 16/07/2012 15:52:45:<br
/>>><br />> >> From: Dave Page <dpage@pgadmin.org><br />> >> To: Martin French
<Martin.French@romaxtech.com>,<br/>> >> Cc: pgadmin-hackers@postgresql.org<br />> >> Date:
16/07/201218:55<br />> >> Subject: Re: [pgadmin-hackers] Propsed pgagent patch: pgAgent<br />> >>
reportsfailure upon success - For Review<br />> >> Sent by: pgadmin-hackers-owner@postgresql.org<br />>
><br/>> ><br />> >><br />> >> Hi<br />> >><br />> >> Can you resend the
patchas an attachment please? It's getting<br />> >> corrupted inline in email.<br />> >><br />>
>>Thanks.<br />> >><br />> >> On Mon, Jul 16, 2012 at 2:46 PM, Martin French<br />> >>
<Martin.French@romaxtech.com>wrote:<br />> >> > Hi,<br />> >> ><br />> >> > I
haveattempted a patch for an issue where pgAgent incorrectly reports<br />> >> > failure on a plain SQL
job.Please see below.<br />> >> ><br />> >> > Feedback/comments welcome.<br />> >>
><br/>> >> > Thanks<br />> >> ><br />> >> > Martin French.<br />> >>
><br/>> >> ><br />> ><br />> >><br />> >><br />> >><br />> >>
--<br/>> >> Dave Page<br />> >> Blog: <a
href="http://pgsnake.blogspot.com">http://pgsnake.blogspot.com</a><br/>> >> Twitter: @pgsnake<br />>
>><br/>> >> EnterpriseDB UK: <a href="http://www.enterprisedb.com">http://www.enterprisedb.com</a><br
/>>>> The Enterprise PostgreSQL Company<br />> >><br />> >> --<br />> >> Sent via
pgadmin-hackersmailing list (pgadmin-hackers@postgresql.org)<br />> >> To make changes to your
subscription:<br/>> >> <a
href="http://www.postgresql.org/mailpref/pgadmin-hackers">http://www.postgresql.org/mailpref/pgadmin-hackers</a><br
/>>>><br />> ><br />> > Patch attached. Apologies for that. :)<br />> ><br />> >
Cheers<br/>> ><br />> > Martin French<br />> <br />> <br />> <br />> -- <br />> Dave Page<br
/>>Blog: <a href="http://pgsnake.blogspot.com">http://pgsnake.blogspot.com</a><br />> Twitter: @pgsnake<br />>
<br/>> EnterpriseDB UK: <a href="http://www.enterprisedb.com">http://www.enterprisedb.com</a><br />> The
EnterprisePostgreSQL Company<br />> <br /></font></tt><br /><tt><font size="2">The patch was generated with git
diff.I've just picked up the file off the box with WinSCP directly and emailed it...</font></tt><br /><br /><tt><font
size="2">I'veFTP'd to my local machine this time...</font></tt><br /><br /><tt><font size="2">cheers</font></tt><br
/><br/><i>(See attached file: pgagent.patch)</i><br /><font
face="sans-serif">=============================================Romax Technology Limited Rutherford House Nottingham
Science& Technology Park Nottingham, NG7 2PZ England Telephone numbers: +44 (0)115 951 88 00 (main) For other
officelocations see: http://www.romaxtech.com/Contact ================================= =============== E-mail:
info@romaxtech.comWebsite: www.romaxtech.com ================================= ================ Confidentiality
StatementThis transmission is for the addressee only and contains information that is confidential and privileged.
Unlessyou are the named addressee, or authorised to receive it on behalf of the addressee you may not copy or use it,
ordisclose it to anyone else. If you have received this transmission in error please delete from your system and
contactthe sender. Thank you for your cooperation. =================================================</font>