On Fri, 16 Sep 2022 at 11:51, John Naylor <john.naylor@enterprisedb.com> wrote:
> On Fri, Sep 16, 2022 at 10:11 AM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
>>
>> At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li <japinli@hotmail.com> wrote in
>> >
>> > Hi hacker,
>> >
>> > Recently, I find there might be a typo in xact.c comments. The comments
>> > say "PG_PROC", however, it actually means "PGPROC" structure. Since we
>> > have pg_proc catalog, and use PG_PROC to reference the catalog [1], so,
>> > we should use PGPROC to reference the structure. Any thoughts?
>> >
>> > [1] src/include/nodes/primnodes.h
>>
>> The patch seems to me covering all occurances of PG_PROC as PGPROC.
>
> +1 since this hinders grep-ability.
>
>> I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is
>> quite confusing, too..
>
> It's pretty obvious to me what that refers to in primnodes.h, although
> the capitalization of (some, but not all) catalog names in comments in
> that file is a bit strange. Maybe not worth changing there.
Thanks for the review. I found for system catalog, we often use lower case.
Here attached a new patch to fix it.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.