On Fri, 08 Mar 2024 at 13:21, Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Mar 06, 2024 at 08:24:09AM +0800, Japin Li wrote:
>> On Wed, 06 Mar 2024 at 01:53, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>>> I think if you remove the EEO_CASE(EEOP_LAST) block the warning should
>>> go away. That block is clearly marked as unreachable, so it doesn't
>>> really serve a purpose.
>>
>> Thanks! Fixed as you suggested. Please see v3 patch.
>
> Hmm. I am not sure if this one is a good idea.
Sorry for the late reply!
> This makes the code a
> bit more complicated to grasp under EEO_USE_COMPUTED_GOTO with the
> reverse dispatch table, to say the least.
I'm not get your mind. Could you explain in more detail?