Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
| От | Chao Li |
|---|---|
| Тема | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Дата | |
| Msg-id | FD184796-6F6E-4D08-9320-9DD89D96B178@gmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments (Aleksander Alekseev <aleksander@tigerdata.com>) |
| Список | pgsql-hackers |
> On Nov 10, 2025, at 17:28, Aleksander Alekseev <aleksander@tigerdata.com> wrote: > >> 1. I just ran the patched pgindent against a random file, then I got a lot diffs like: >> >> ``` >> /* >> - * Direct advancement: avoid waking non-caught up backends that >> - * aren't interested in our notifications. >> + * Direct advancement: avoid waking non-caught up backends that aren't >> + * interested in our notifications. >> */ >> ``` > > I'm not sure if this is part of the PostgreSQL code base either. My > best guess is that something is wrong with whitespaces here (tabs vs > spaces). We have plenty of multiline comments like this and from what > I can tell they are processed correctly. I recalled that. I ran pgindent on a file from a patch I was reviewing, so, the file was not pgindent-ed yet at the time. I just tried to run the patched pgindent on several files and no diff generated. So this comment is resolved. Regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
В списке pgsql-hackers по дате отправления: