Re: [bug fix] Memory leak in dblink

Поиск
Список
Период
Сортировка
От MauMau
Тема Re: [bug fix] Memory leak in dblink
Дата
Msg-id FC0B2DE4D8E147018FEC13A9371B98A6@maumau
обсуждение исходный текст
Ответ на Re: [bug fix] Memory leak in dblink  (Joe Conway <mail@joeconway.com>)
Ответы Re: [bug fix] Memory leak in dblink
Список pgsql-hackers
From: "Joe Conway" <mail@joeconway.com>
> I think the context deletion was missed in the first place because
> storeRow() is the wrong place to create the context. Rather than
> creating the context in storeRow() and deleting it two levels up in
> materializeQueryResult(), I think it should be created and deleted in
> the interim layer, storeQueryResult(). Patch along those lines attached.
>
> Any objections to me back-patching it this way?

I thought the same at first before creating the patch, but I reconsidered. 
If the query executed by dblink() doesn't return any row, the context 
creation and deletion is a waste of processing.  I think the original author 
wanted to eliminate this waste by creating the context when dblink() should 
return a row.  I'd like to respect his thought.

Regards
MauMau




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Merlin Moncure
Дата:
Сообщение: Re: Atomics hardware support table & supported architectures
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: Atomics hardware support table & supported architectures