Re: doc: Clarify that empty COMMENT string removes the comment
| От | Chao Li |
|---|---|
| Тема | Re: doc: Clarify that empty COMMENT string removes the comment |
| Дата | |
| Msg-id | F88CAD6A-7CD2-445D-AE79-76F3F827B296@gmail.com обсуждение исходный текст |
| Ответ на | Re: doc: Clarify that empty COMMENT string removes the comment (Fujii Masao <masao.fujii@gmail.com>) |
| Ответы |
Re: doc: Clarify that empty COMMENT string removes the comment
|
| Список | pgsql-hackers |
> On Mar 3, 2026, at 08:28, Fujii Masao <masao.fujii@gmail.com> wrote: > > On Tue, Mar 3, 2026 at 8:42 AM Chao Li <li.evan.chao@gmail.com> wrote: >> >> >> >>> On Feb 28, 2026, at 09:21, David G. Johnston <david.g.johnston@gmail.com> wrote: >>> >>> On Fri, Feb 27, 2026 at 5:12 PM Chao Li <li.evan.chao@gmail.com> wrote: >>> >>> PFA v3. > > Thanks for updating the patch! LGTM > > One more comment: the handling of empty-string comments exists in both > CreateComments() and CreateSharedComments(). For better test coverage, > how about adding also the regression test to check that COMMENT with > empty-string works as expected for shared objects such as roles? > Sure. CreateSharedComments() handles database, tablespace and role, so as you suggested, I added tests for role in v4. > From: zhangqiang <zhang_qiang81@163.com> > > Hi hackers,I have verified that using an empty string does indeed delete comments. I agree this patch content enables usersto better understand how the database program handles empty strings when using the COMMENT ON command in documentation,thereby improving the user experience.I think it's a good patch. > Thanks for your review. Sounds good. PFA v4: * Add tests that use NULL and ‘’ to remove comments from a role object. Best regards -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
Вложения
В списке pgsql-hackers по дате отправления: