Re: Is it correct to update db state in control file as "shutting down" during end-of-recovery checkpoint?

On 12/8/21, 3:29 AM, "Bharath Rupireddy" <bharath.rupireddyforpostgres@gmail.com> wrote:
> Thanks for your thoughts. I'm fine either way, hence attaching two
> patches here with and I will leave it for the committer 's choice.
> 1) v1-0001-Add-DB_IN_END_OF_RECOVERY_CHECKPOINT-state-for-co.patch --
> adds new db state DB_IN_END_OF_RECOVERY_CHECKPOINT for control file.
> 2) v1-0001-Skip-control-file-db-state-updation-during-end-of.patch --
> just skips setting db state to DB_SHUTDOWNING and DB_SHUTDOWNED in
> case of end-of-recovery checkpoint so that the state will be
> DB_IN_CRASH_RECOVERY which then changes to DB_IN_PRODUCTION.

I've bumped this one to ready-for-committer.  For the record, my
preference is the second patch (for the reasons discussed upthread).
Both patches might benefit from a small comment or two, too.

Nathan