Re: Problem with MSVC install script

Of course it is better not to remove the readonly on all files in the
target dir.  That's just a workaround I did because it didn't involve
changing the perl scripts.
I don't know the "right" perl way to change the readonly attribute on a
file.  If there isn't one, you could have the perl code issue "attrib"
commands on the target location for each file it is moving.  Better if
there is some more "perl" way to do this.

> -----Original Message-----
> From: Magnus Hagander [mailto:magnus@hagander.net]
> Sent: Monday, September 24, 2007 12:33 AM
> To: Chuck McDevitt
> Cc: Andrew Dunstan; pgsql-hackers@postgresql.org
> Subject: Re: [HACKERS] Problem with MSVC install script
>
> Hrrm. I wonder how likely that is, but I can see it's a problem.
>
> That said, it's probably not a bad idea to fix it anyway - it would
> correspond to setting the permissions on a unix install, which we do.
>
> For the xcopy commansd, it should be easier to just add a /R switch.
> But
> most files are copied using the internal perl stuff - anybody know if
> those
> can be made to overwrite readonly files easily?
>
> Also, do we really want to remove the readonly file on all the files
in
> the
> target dir including subdirs? That may hit a bunch of files that
aren't
> actualliy "ours". Perhaps we need to process it on a file-by-file
> basis?
>
> //Magnus
>
> On Mon, Sep 24, 2007 at 02:59:54AM -0400, Chuck McDevitt wrote:
> > Well, I was checking out from a different cvs server, and had things
> set
> > to use CVS EDIT, where everything is read-only by default, until you
> > issue a cvs edit command.
> > So many files that aren't built by the build system, but just get
> copied
> > as-is, end up read-only.
> >
> > But it would be true for any files set read-only.
> >
> > > -----Original Message-----
> > > From: Andrew Dunstan [mailto:andrew@dunslane.net]
> > > Sent: Sunday, September 23, 2007 7:45 PM
> > > To: Chuck McDevitt
> > > Cc: pgsql-hackers@postgresql.org
> > > Subject: Re: [HACKERS] Problem with MSVC install script
> > >
> > >
> > >
> > > Chuck McDevitt wrote:
> > > >
> > > > I was trying out the msvc support, and ran into a minor problem
> in
> > > the
> > > > install.bat/install.pl
> > > >
> > > > If any files that are going to be installed are marked
read-only,
> > > they
> > > > carry the read-only attribute with them when they get copied to
> the
> > > > install dir.
> > > >
> > > > Then, if you try to run install again, the new attempt will fail
> > > > because it can't overwrite the read-only file.
> > > >
> > > > I added this like to install.bat (just before the call to
> > install.pl)
> > > > to fix this for me:
> > > >
> > > > attrib /S -r %1\*
> > > >
> > >
> > >
> > > Which files are read-only?
> > >
> > > cheers
> > >
> > > andrew
> >
> >
> > ---------------------------(end of
broadcast)------------------------
> ---
> > TIP 1: if posting/reading through Usenet, please send an appropriate
> >        subscribe-nomail command to majordomo@postgresql.org so that
> your
> >        message can get through to the mailing list cleanly