Re: Schema support

Patch applied.


> -----Original Message-----
> From: pgsql-odbc-owner@postgresql.org
> [mailto:pgsql-odbc-owner@postgresql.org] On Behalf Of Dave Page
> Sent: 04 October 2004 22:16
> To: pgsql-odbc@postgresql.org
> Subject: [ODBC] Schema support
>
> There have been a couple of reports that psqlODBC does not
> support schemas. This is not strictly true, it actually has
> full support for schemas, however, SQLTables honours the
> search_path variable on the server and hides objects in
> schemas that are not visible.
>
> I'm not convinced this is the correct behaviour - SQLTables
> should show everything afaict, unless a parameter is passed
> to it to filter the output. The micro-patch below corrects
> this - however I'm not 100% sure there won't be any side
> effects I haven't thought of. I'd appreciate it if I could
> get some feedback.
>
> Thanks Dave.
>
> Index: info.c
> ===================================================================
> RCS file: /usr/local/cvsroot/psqlodbc/psqlodbc/info.c,v
> retrieving revision 1.114
> diff -u -r1.114 info.c
> --- info.c    26 Jul 2004 14:10:37 -0000    1.114
> +++ info.c    4 Oct 2004 20:59:31 -0000
> @@ -1284,7 +1284,6 @@
>      if (conn->schema_support)
>      {
>          schema_strcat1(tables_query, " and nspname %s
> '%.*s'", likeeq, szSchemaName, cbSchemaName, szTableName,
> cbTableName, conn);
> -        strcat(tables_query, " and
> pg_catalog.pg_table_is_visible(c.oid)");
>      }
>      else
>          my_strcat1(tables_query, " and usename %s
> '%.*s'", likeeq, szSchemaName, cbSchemaName);
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
>                http://archives.postgresql.org
>