pgsql: Use proc_exit() for walreceiver exit in WalRcvWaitForStartPositi

Use proc_exit() for walreceiver exit in WalRcvWaitForStartPosition()

Previously, when the walreceiver exited from WalRcvWaitForStartPosition()
at the startup process's request, it called exit(1) directly. This could
skip cleanup performed by the callback functions.

This commit makes the walreceiver to use proc_exit() instead, ensuring
normal cleanup is executed on exit.

Also this commit updates comments describing walreceiver termination.

Apply to master only, as this has not caused practical issues so far.

Author: Chao Li <lic@highgo.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Andreas Karlsson <andreas@proxel.se>
Reviewed-by: Xuneng Zhou <xunengzhou@gmail.com>
Discussion: https://postgr.es/m/74381238-4E8A-4621-B794-57025DCCE0BA@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ee550254a29a4ccd3852f14b1806b8ffe26b7454

Modified Files
--------------
src/backend/replication/walreceiver.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)