pgsql: Check that the tranche name is unique in RequestNamedLWLockTranc

Check that the tranche name is unique in RequestNamedLWLockTranche

You could request two tranches with same name, but things would get
confusing when you called GetNamedLWLockTranche() to get the LWLocks
allocated for them; it would always return the first tranche with the
name. That doesn't make sense, so forbid duplicates.

We still allow duplicates with LWLockNewTrancheId(). That works better
as you don't use the name to look up the tranche ID later. It's still
confusing in wait events, for example, but it's not dangerous in the
same way.

Reviewed-by: Sami Imseih <samimseih@gmail.com>
Discussion: https://www.postgresql.org/message-id/463a28db-0c0b-4af6-bac6-3891828bbbfe@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f10b6be2581f879f24a4830443bab356ec6d71c5

Modified Files
--------------
src/backend/storage/lmgr/lwlock.c | 7 +++++++
1 file changed, 7 insertions(+)