pgsql: xml2: Fix failure with xslt_process() under -fsanitize=undefined

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема pgsql: xml2: Fix failure with xslt_process() under -fsanitize=undefined
Дата
Msg-id E1w0wcT-003jQi-0o@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
xml2: Fix failure with xslt_process() under -fsanitize=undefined

The logic of xslt_process() has never considered the fact that
xsltSaveResultToString() would return NULL for an empty string (the
upstream code has always done so, with a string length of 0).  This
would cause memcpy() to be called with a NULL pointer, something
forbidden by POSIX.

Like 46ab07ffda9d and similar fixes, this is backpatched down to all the
supported branches, with a test case to cover this scenario.  An empty
string has been always returned in xml2 in this case, based on the
history of the module, so this is an old issue.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/c516a0d9-4406-47e3-9087-5ca5176ebcf9@gmail.com
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/70f7c5badcc069560993faabc744466804446246

Modified Files
--------------
contrib/xml2/expected/xml2.out   | 10 ++++++++++
contrib/xml2/expected/xml2_1.out |  6 ++++++
contrib/xml2/sql/xml2.sql        |  6 ++++++
contrib/xml2/xslt_proc.c         |  9 ++++++++-
4 files changed, 30 insertions(+), 1 deletion(-)


В списке pgsql-committers по дате отправления: