pgsql: Fix const correctness in pgstat data serialization callbacks
| От | Michael Paquier |
|---|---|
| Тема | pgsql: Fix const correctness in pgstat data serialization callbacks |
| Дата | |
| Msg-id | E1vW05y-001JUb-1f@gemulon.postgresql.org обсуждение исходный текст |
| Список | pgsql-committers |
Fix const correctness in pgstat data serialization callbacks 4ba012a8ed9c defined the "header" (pointer to the stats data) of from_serialized_data() as a const, even though it is fine (and expected!) for the callback to modify the shared memory entry when loading the stats at startup. While on it, this commit updates the callback to_serialized_data() in the test module test_custom_stats to make the data extracted from the "header" parameter a const since it should never be modified: the stats are written to disk and no modifications are expected in the shared memory entry. This clarifies the API contract of these new callbacks. Reported-By: Peter Eisentraut <peter@eisentraut.org> Author: Michael Paquier <michael@paquier.xyz> Co-authored-by: Sami Imseih <samimseih@gmail.com> Discussion: https://postgr.es/m/d87a93b0-19c7-4db6-b9c0-d6827e7b2da1@eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/167cb26718e3eae4fef470900b4cd1d434f15649 Modified Files -------------- src/include/utils/pgstat_internal.h | 5 +++-- src/test/modules/test_custom_stats/test_custom_var_stats.c | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-)
В списке pgsql-committers по дате отправления: