pgsql: formatting.c cleanup: Change fill_str() return type to void

formatting.c cleanup: Change fill_str() return type to void

The return value is not used anywhere.

In passing, add a comment explaining the function's arguments.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/6dd9d208-a3ed-49b5-b03d-8617261da973%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/aa4535307e3d432f44b4c76b8ffebc5a0789250c

Modified Files
--------------
src/backend/utils/adt/formatting.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)