pgsql: Make invalid primary_slot_name follow standard GUC error reporti

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема pgsql: Make invalid primary_slot_name follow standard GUC error reporti
Дата
Msg-id E1vBWpB-002wJR-1I@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Make invalid primary_slot_name follow standard GUC error reporting.

Previously, if primary_slot_name was set to an invalid slot name and
the configuration file was reloaded, both the postmaster and all other
backend processes reported a WARNING. With many processes running,
this could produce a flood of duplicate messages. The problem was that
the GUC check hook for primary_slot_name reported errors at WARNING
level via ereport().

This commit changes the check hook to use GUC_check_errdetail() and
GUC_check_errhint() for error reporting. As with other GUC parameters,
this causes non-postmaster processes to log the message at DEBUG3,
so by default, only the postmaster's message appears in the log file.

Backpatch to all supported versions.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <lic@highgo.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Discussion: https://postgr.es/m/CAHGQGwFud-cvthCTfusBfKHBS6Jj6kdAPTdLWKvP2qjUX6L_wA@mail.gmail.com
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b00a16baeb2ab8551ae752e86263e1c0bfc52d9c

Modified Files
--------------
src/backend/replication/slot.c | 59 +++++++++++++++++++++++++++++++-----------
src/backend/utils/misc/guc.c   | 13 +++++++++-
src/include/replication/slot.h |  2 ++
3 files changed, 58 insertions(+), 16 deletions(-)


В списке pgsql-committers по дате отправления: