pgsql: Use SOCK_ERRNO[_SET] in fe-secure-gssapi.c.
От | Tom Lane |
---|---|
Тема | pgsql: Use SOCK_ERRNO[_SET] in fe-secure-gssapi.c. |
Дата | |
Msg-id | E1v5VKw-000E3p-0q@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Use SOCK_ERRNO[_SET] in fe-secure-gssapi.c. On Windows, this code did not handle error conditions correctly at all, since it looked at "errno" which is not used for socket-related errors on that platform. This resulted, for example, in failure to connect to a PostgreSQL server with GSSAPI enabled. We have a convention for dealing with this within libpq, which is to use SOCK_ERRNO and SOCK_ERRNO_SET rather than touching errno directly; but the GSSAPI code is a relative latecomer and did not get that memo. (The equivalent backend code continues to use errno, because the backend does this differently. Maybe libpq's approach should be rethought someday.) Apparently nobody tries to build libpq with GSSAPI support on Windows, or we'd have heard about this before, because it's been broken all along. Back-patch to all supported branches. Author: Ning Wu <ning94803@gmail.com> Co-authored-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAFGqpvg-pRw=cdsUpKYfwY6D3d-m9tw8WMcAEE7HHWfm-oYWvw@mail.gmail.com Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ea78bd6d5d0f18c09db1e3ec6fd19be38d706030 Modified Files -------------- src/interfaces/libpq/fe-secure-gssapi.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-)
В списке pgsql-committers по дате отправления: