pgsql: Revert "Get rid of WALBufMappingLock"
От | Alexander Korotkov |
---|---|
Тема | pgsql: Revert "Get rid of WALBufMappingLock" |
Дата | |
Msg-id | E1upUge-0019nG-0P@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Revert "Get rid of WALBufMappingLock" This reverts commit bc22dc0e0ddc2dcb6043a732415019cc6b6bf683. It appears that conditional variables are not suitable for use inside critical sections. If WaitLatch()/WaitEventSetWaitBlock() face postmaster death, they exit, releasing all locks instead of PANIC. In certain situations, this leads to data corruption. Reported-by: Andrey Borodin <x4mmm@yandex-team.ru> Discussion: https://postgr.es/m/B3C69B86-7F82-4111-B97F-0005497BB745%40yandex-team.ru Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Reviewed-by: Aleksander Alekseev <aleksander@tigerdata.com> Reviewed-by: Kirill Reshke <reshkekirill@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Reviewed-by: Tomas Vondra <tomas@vondra.me> Reviewed-by: Andres Freund <andres@anarazel.de> Reviewed-by: Yura Sokolov <y.sokolov@postgrespro.ru> Reviewed-by: Michael Paquier <michael@paquier.xyz> Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2ce6abdf50857d3564cc1ef701e7f1095fbfb438 Modified Files -------------- src/backend/access/transam/xlog.c | 234 +++++------------------- src/backend/utils/activity/wait_event_names.txt | 2 +- src/include/storage/lwlocklist.h | 2 +- 3 files changed, 49 insertions(+), 189 deletions(-)
В списке pgsql-committers по дате отправления: