pgsql: Allow resetting iso-8859-1 custom GUCs with reserved prefixes.
От | Nathan Bossart |
---|---|
Тема | pgsql: Allow resetting iso-8859-1 custom GUCs with reserved prefixes. |
Дата | |
Msg-id | E1uhxj3-000Fyk-2h@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Allow resetting unknown custom GUCs with reserved prefixes. Currently, ALTER DATABASE/ROLE/SYSTEM RESET [ALL] with an unknown custom GUC with a prefix reserved by MarkGUCPrefixReserved() errors (unless a superuser runs a RESET ALL variant). This is problematic for cases such as an extension library upgrade that removes a GUC. To fix, simply make sure the relevant code paths explicitly allow it. Note that we require superuser or privileges on the parameter to reset it. This is perhaps a bit more restrictive than is necessary, but it's not clear whether further relaxing the requirements is safe. Oversight in commit 88103567cb. The ALTER SYSTEM fix is dependent on commit 2d870b4aef, which first appeared in v17. Unfortunately, back-patching that commit would introduce ABI breakage, and while that breakage seems unlikely to bother anyone, it doesn't seem worth the risk. Hence, the ALTER SYSTEM part of this commit is omitted on v15 and v16. Reported-by: Mert Alev <mert@futo.org> Reviewed-by: Laurenz Albe <laurenz.albe@cybertec.at> Discussion: https://postgr.es/m/18964-ba09dea8c98fccd6%40postgresql.org Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b998ce3272ab45877f760ff558906a967b6a7da6 Modified Files -------------- contrib/auto_explain/Makefile | 2 ++ contrib/auto_explain/expected/alter_reset.out | 17 +++++++++++++++++ contrib/auto_explain/meson.build | 5 +++++ contrib/auto_explain/sql/alter_reset.sql | 20 ++++++++++++++++++++ src/backend/utils/misc/guc.c | 14 ++++++++++---- 5 files changed, 54 insertions(+), 4 deletions(-)
В списке pgsql-committers по дате отправления: