pgsql: Fix conversion of SIMILAR TO regexes for character classes
От | Michael Paquier |
---|---|
Тема | pgsql: Fix conversion of SIMILAR TO regexes for character classes |
Дата | |
Msg-id | E1uK4DB-000LnB-2r@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix conversion of SIMILAR TO regexes for character classes The code that translates SIMILAR TO pattern matching expressions to POSIX-style regular expressions did not consider that square brackets can be nested. For example, in an expression like [[:alpha:]%_], the logic replaced the placeholders '_' and '%' but it should not. This commit fixes the conversion logic by tracking the nesting level of square brackets marking character class areas, while considering that in expressions like []] or [^]] the first closing square bracket is a regular character. Multiple tests are added to show how the conversions should or should not apply applied while in a character class area, with specific cases added for all the characters converted outside character classes like an opening parenthesis '(', dollar sign '$', etc. Author: Laurenz Albe <laurenz.albe@cybertec.at> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/16ab039d1af455652bdf4173402ddda145f2c73b.camel@cybertec.at Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e3ffc3e91d04579240fb54a96f9059b246488dce Modified Files -------------- src/backend/utils/adt/regexp.c | 38 +++++++++++++++++---- src/test/regress/expected/strings.out | 62 +++++++++++++++++++++++++++++++++++ src/test/regress/sql/strings.sql | 20 +++++++++++ 3 files changed, 114 insertions(+), 6 deletions(-)
В списке pgsql-committers по дате отправления: