pgsql: Fix freeing a child join's SpecialJoinInfo
От | Richard Guo |
---|---|
Тема | pgsql: Fix freeing a child join's SpecialJoinInfo |
Дата | |
Msg-id | E1tkYWi-000345-2q@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix freeing a child join's SpecialJoinInfo In try_partitionwise_join, we try to break down the join between two partitioned relations into joins between matching partitions. To achieve this, we iterate through each pair of partitions from the two joining relations and create child join relations for them. To reduce memory accumulation during each iteration, one step we take is freeing the SpecialJoinInfos created for the child joins. A child join's SpecialJoinInfo is a copy of the parent join's SpecialJoinInfo, with some members being translated copies of their counterparts in the parent. However, when freeing the bitmapset members in a child join's SpecialJoinInfo, we failed to check whether they were translated copies. As a result, we inadvertently freed the members that were still in use by the parent SpecialJoinInfo, leading to crashes when those freed members were accessed. To fix, check if each member of the child join's SpecialJoinInfo is a translated copy and free it only if that's the case. This requires passing the parent join's SpecialJoinInfo as a parameter to free_child_join_sjinfo. Back-patch to v17 where this bug crept in. Bug: #18806 Reported-by: 孟令彬 <m_lingbin@126.com> Diagnosed-by: Tender Wang <tndrwang@gmail.com> Author: Richard Guo <guofenglinux@gmail.com> Reviewed-by: Amit Langote <amitlangote09@gmail.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Discussion: https://postgr.es/m/18806-d70b0c9fdf63dcbf@postgresql.org Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c39392ebaeeff7dafbc255844bcc605aaef01d7d Modified Files -------------- src/backend/optimizer/path/joinrels.c | 34 ++++++++++++++++++++------- src/test/regress/expected/partition_join.out | 35 ++++++++++++++++++++++++++++ src/test/regress/sql/partition_join.sql | 4 ++++ 3 files changed, 64 insertions(+), 9 deletions(-)
В списке pgsql-committers по дате отправления: