pgsql: Implement new optimization rule for updates of expanded variable
От | Tom Lane |
---|---|
Тема | pgsql: Implement new optimization rule for updates of expanded variable |
Дата | |
Msg-id | E1thuOI-006aao-2h@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Implement new optimization rule for updates of expanded variables. If a read/write expanded variable is declared locally to the assignment statement that is updating it, and it is referenced exactly once in the assignment RHS, then we can optimize the operation as a direct update of the expanded value, whether or not the function(s) operating on it can be trusted not to modify the value before throwing an error. This works because if an error does get thrown, we no longer care what value the variable has. In cases where that doesn't work, fall back to the previous rule that checks for safety of the top-level function. In any case, postpone determination of whether these optimizations are feasible until we are executing a Param referencing the target variable and that variable holds a R/W expanded object. While the previous incarnation of exec_check_rw_parameter was pretty cheap, this is a bit less so, and our plan to invoke support functions will make it even less so. So avoiding the check for variables where it couldn't be useful should be a win. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Reviewed-by: Pavel Borisov <pashkin.elfe@gmail.com> Discussion: https://postgr.es/m/CACxu=vJaKFNsYxooSnW1wEgsAO5u_v1XYBacfVJ14wgJV_PYeg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6c7251db0ce12a83dd03c840e7d0ff7516b27229 Modified Files -------------- src/include/executor/execExpr.h | 1 + src/pl/plpgsql/src/expected/plpgsql_array.out | 9 + src/pl/plpgsql/src/pl_exec.c | 383 ++++++++++++++++++++++---- src/pl/plpgsql/src/plpgsql.h | 22 +- src/pl/plpgsql/src/sql/plpgsql_array.sql | 9 + src/tools/pgindent/typedefs.list | 2 + 6 files changed, 364 insertions(+), 62 deletions(-)
В списке pgsql-committers по дате отправления: