pgsql: Use the correct sizeof() in BufFileLoadBuffer

Поиск
Список
Период
Сортировка
От Tomas Vondra
Тема pgsql: Use the correct sizeof() in BufFileLoadBuffer
Дата
Msg-id E1tbUnf-003MFL-3c@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Use the correct sizeof() in BufFileLoadBuffer

The sizeof() call should reference buffer.data, because that's the
buffer we're reading data into, not the whole PGAlignedBuffer union.
This was introduced by 44cac93464, which replaced the simple buffer
with a PGAlignedBuffer field.

It's benign, because the buffer is the largest field of the union, so
the sizes are the same. But it's easy to trip over this in a patch, so
fix and backpatch. Commit 44cac93464 went into 12, but that's EOL.

Backpatch-through: 13
Discussion: https://postgr.es/m/928bdab1-6567-449f-98c4-339cd2203b87@vondra.me

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/50cd651254354397ca2f2b795dd6aac300826076

Modified Files
--------------
src/backend/storage/file/buffile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


В списке pgsql-committers по дате отправления: