pgsql: pg_basebackup, pg_receivewal: fix failure to find password in ~/
От | Tom Lane |
---|---|
Тема | pgsql: pg_basebackup, pg_receivewal: fix failure to find password in ~/ |
Дата | |
Msg-id | E1t82sA-000BlL-QN@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
pg_basebackup, pg_receivewal: fix failure to find password in ~/.pgpass. Sloppy refactoring in commit cca97ce6a caused these programs to pass dbname = NULL to libpq if there was no "--dbname" switch on the command line, where before "replication" would be passed. This didn't break things completely, because the source server doesn't care about the dbname specified for a physical replication connection. However, it did cause libpq to fail to match a ~/.pgpass entry that has "replication" in the dbname field. Restore the previous behavior of passing "replication". Also, closer inspection shows that if you do specify a dbname in the connection string, that is what will be matched to ~/.pgpass, not "replication". This was the pre-existing behavior so we should not change it, but the SGML docs were pretty misleading about it. Improve that. Per bug #18685 from Toshi Harada. Back-patch to v17 where the error crept in. Discussion: https://postgr.es/m/18685-fee2dd142b9688f1@postgresql.org Discussion: https://postgr.es/m/2702546.1730740456@sss.pgh.pa.us Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e2a912909308041d629f1e62ea84c76d179674b1 Modified Files -------------- doc/src/sgml/ref/pg_basebackup.sgml | 16 ++++++++++------ doc/src/sgml/ref/pg_receivewal.sgml | 13 ++++++++----- src/bin/pg_basebackup/streamutil.c | 9 ++++++--- 3 files changed, 24 insertions(+), 14 deletions(-)
В списке pgsql-committers по дате отправления: