pgsql: Fix extreme skew detection in Parallel Hash Join.
От | Thomas Munro |
---|---|
Тема | pgsql: Fix extreme skew detection in Parallel Hash Join. |
Дата | |
Msg-id | E1t1Mu8-001DVi-UJ@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix extreme skew detection in Parallel Hash Join. After repartitioning the inner side of a hash join that would have exceeded the allowed size, we check if all the tuples from a parent partition moved to one child partition. That is evidence that it contains duplicate keys and later attempts to repartition will also fail, so we should give up trying to limit memory (for lack of a better fallback strategy). A thinko prevented the check from working correctly in partition 0 (the one that is partially loaded into memory already). After repartitioning, we should check for extreme skew if the *parent* partition's space_exhausted flag was set, not the child partition's. The consequence was repeated futile repartitioning until per-partition data exceeded various limits including "ERROR: invalid DSA memory alloc request size 1811939328", OS allocation failure, or temporary disk space errors. (We could also do something about some of those symptoms, but that's material for separate patches.) This problem only became likely when PostgreSQL 16 introduced support for Parallel Hash Right/Full Join, allowing NULL keys into the hash table. Repartitioning always leaves NULL in partition 0, no matter how many times you do it, because the hash value is all zero bits. That's unlikely for other hashed values, but they might still have caused wasted extra effort before giving up. Back-patch to all supported releases. Reported-by: Craig Milhiser <craig@milhiser.com> Reviewed-by: Andrei Lepikhov <lepihov@gmail.com> Discussion: https://postgr.es/m/CA%2BwnhO1OfgXbmXgC4fv_uu%3DOxcDQuHvfoQ4k0DFeB0Qqd-X-rQ%40mail.gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4fa80a6d7d4bde83065a5e1d84c01522d2fd368c Modified Files -------------- src/backend/executor/nodeHash.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
В списке pgsql-committers по дате отправления: